Github Pull Requests

Discussion in 'Technical Development' started by Neurosploit, Feb 20, 2016.

  1. 2017/12/15 - Decred v1.1.2 released! → Release Notes  → Downloads
  1. Neurosploit

    Neurosploit New Member

    Jan 19, 2016
    36
    13
    Male
    .NET Software Engineer
    Amsterdam
    I've branched the master of decred/copay in github desktop to a new local branch. In this branch I've fixed the javascript unit testing so that we can finally start testing some of the code in that repository.
    However, I'm not able to create a pull request from my local branch to the master in github desktop. It states I don't have enough permission for that. I'm not that used to git as I use tfs in normal day to day work.
    Can anybody help me in sending in the pull request? Do I need additional rights to send it or is it configured in a way that I need to fork it first and then send the pull request from my own fork?
     
    sambiohazard likes this.
  2. chappjc

    chappjc Full Member
    Developer Pool Operator (PoS)

    Perhaps you already are, but you need to work on a fork of your own (e.g. neurosploit/copay), not just a local branch of decred/copay. Can you describe your working environment and exactly how you did a commit and push?

    I didn't have any trouble creating pull requests to the cgminer repository. I use the command line `git` to commit then push my changes to a branch in my own fork of cgminer (currently out of date). Then I created a pull request on the web page. Here's one that was merged, for example.

    Perhaps you need to reverse the direction of the pull request on the github we interface? I found it somewhat counter-intuitive.
     
  3. Neurosploit

    Neurosploit New Member

    Jan 19, 2016
    36
    13
    Male
    .NET Software Engineer
    Amsterdam
    #3 Neurosploit, Feb 22, 2016
    Last edited: Feb 22, 2016
    Done. The pull request is sent and pending and I'm already working on tests.
     
    sambiohazard likes this.

Share This Page